Expose changeset content #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also rename it to |
|
Awesome, thanks for taking the time @makepanic. I'll review this after work today. |
nucleartide
suggested changes
Feb 21, 2018
README.md
Outdated
|
|
||
| ```js | ||
| let user = { name: 'Bobby', age: 21, address: { zipCode: '10001' } }; | ||
|
|
There was a problem hiding this comment.
Add let changeset = new Changeset(user);?
addon/index.js
Outdated
| @@ -177,6 +181,7 @@ export function changeset( | |||
| errors: objectToArray(ERRORS, (e /*: Err */) => ({ value: e.value, validation: e.validation }), true), | |||
| change: inflate(CHANGES, c => c.value), | |||
| error: inflate(ERRORS, e => ({ value: e.value, validation: e.validation })), | |||
| content: reads(CONTENT).readOnly(), | |||
There was a problem hiding this comment.
Could this be readOnly(CONTENT), without the reads?
tests/unit/changeset-test.js
Outdated
|
|
||
| assert.throws(() => set(dummyChangeset, 'content', { foo: 'bar' }), ({message}) => { | ||
| return message === "Cannot set read-only property 'content' on object: changeset:[object Object]"; | ||
| }, 'should throw error'); |
There was a problem hiding this comment.
assert.throws(
() => set(dummyChangeset, 'content', { foo: 'bar' }),
({ message }) => message === "Cannot set read-only property 'content' on object: changeset:[object Object]",
'should throw error'
);Would like to see the args on separate lines just for clarity. :)
makepanic
force-pushed
the
content-getter
branch
from
4c8dcdb to
adaa0b2
Compare
|
I've made the requested changes and renamed the attribute to |
|
@makepanic Wrote up some release notes and published the latest on npm, thanks for the PR dude! Lemme know if there are any problems. |
|
I don't believe this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR adds a new readonly getter that returns the object that was wrapped in the changeset.
The change can potentially close #139 as it exposes a way to access
_content.I'm unsure if
contentis a good name as it potentially conflicts with the proxied objectscontentattribute.