-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validated-changeset - exit beta #391
Conversation
@snewcomer I'm not comfortable with this change. You are essentially copying all the code from this repo and creating a new version without any attribution to the original author / contributors. You could have discussed this change with me first. Feel free to DM me on Twitter if you want to chat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment.
As discussed off this thread, this extracted library started initially with the major rewrite we did a few months back to move us off EmberObject to allow its eventual use outside of Ember. The hope is other ecosystems can take advantage of this phenomenal library. As a result, we have moved this base library to it's proper place - https://github.com/validated-changeset/validated-changeset!! Validations, complementary packages to follow... Will update pkg once we can publish a |
https://github.com/validated-changeset/validated-changeset
This PR replaces much of the functionality present in this package with and plain TS library. The goal of this extraction was to use in other contexts and frameworks. We hope that we can obtain greater adoption of these amazing patterns and ideas here. As an aside, we also have better type checks in the underlying pkg.
There are a few spots that are EmberData specific in which inheritance took over from
validated-changeset
. Specificallymerge-deep
and the proxiedget
. We will continue to look for more generic solutions once we are out of beta.@josemarluedke @andreyfel
A 3.0.0 release will follow and we will move out of beta!!