Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validated-changeset - exit beta #391

Merged
merged 18 commits into from
Feb 2, 2020
Merged

validated-changeset - exit beta #391

merged 18 commits into from
Feb 2, 2020

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Dec 27, 2019

https://github.com/validated-changeset/validated-changeset

This PR replaces much of the functionality present in this package with and plain TS library. The goal of this extraction was to use in other contexts and frameworks. We hope that we can obtain greater adoption of these amazing patterns and ideas here. As an aside, we also have better type checks in the underlying pkg.

There are a few spots that are EmberData specific in which inheritance took over from validated-changeset. Specifically merge-deep and the proxied get. We will continue to look for more generic solutions once we are out of beta.

@josemarluedke @andreyfel

A 3.0.0 release will follow and we will move out of beta!!

@snewcomer snewcomer self-assigned this Dec 27, 2019
@poteto
Copy link
Collaborator

poteto commented Dec 27, 2019

@snewcomer I'm not comfortable with this change. You are essentially copying all the code from this repo and creating a new version without any attribution to the original author / contributors. You could have discussed this change with me first. Feel free to DM me on Twitter if you want to chat.

@poteto poteto self-requested a review December 27, 2019 23:51
poteto
poteto previously requested changes Dec 27, 2019
Copy link
Collaborator

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment.

@snewcomer
Copy link
Collaborator Author

snewcomer commented Dec 28, 2019

As discussed off this thread, this extracted library started initially with the major rewrite we did a few months back to move us off EmberObject to allow its eventual use outside of Ember. The hope is other ecosystems can take advantage of this phenomenal library. As a result, we have moved this base library to it's proper place - https://github.com/validated-changeset/validated-changeset!! Validations, complementary packages to follow...

Will update pkg once we can publish a 0.1.0 release! (and sry for not discussion beforehand :(. That is my fault).

@snewcomer snewcomer requested a review from poteto January 25, 2020 22:52
@snewcomer snewcomer dismissed poteto’s stale review January 25, 2020 22:56

Re-requesting review

@snewcomer snewcomer changed the title validated-changeset validated-changeset - exit beta Jan 25, 2020
@snewcomer snewcomer merged commit 54969f6 into master Feb 2, 2020
@snewcomer snewcomer deleted the sn/validated-changeset branch February 2, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants