Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User save test: create user without the profile #405

Closed

Conversation

andreyfel
Copy link
Contributor

Illustration of #403

@snewcomer
Copy link
Collaborator

Is this PR close-able?

Set the profile via the changeset.
This is more common scenario.
@andreyfel
Copy link
Contributor Author

@snewcomer I rebased it and it is still failing. I'm wondering if it is supposed to be supported in this way?

  changeset.set('profile', profile);
  changeset.set('profile.firstName', 'Grace');

@snewcomer
Copy link
Collaborator

Yeah it seems we can't do

options.safeSet(Proxy, 'firstName', next.value);

I wonder why that is 🤔 There is probably something in the merge-deep util we need to look at...

@snewcomer
Copy link
Collaborator

What I am seeing is that you effectively have to set the profile on the user initially. Based on what I understand, this is inherent to ED and not ember-changeset.

This is a minor inconvenience; however, not solvable.

At minimum, we can document our findings. What do you think?

@snewcomer snewcomer closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants