-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix livereload #105
fix livereload #105
Conversation
Ready for a rebase now that #104 has landed |
Rebased and fixed the test that were failing due to leaking state. |
This is not ready yet. This had moved the calculation of config to |
Pushed a new implementation. It's a total rewrite of this PR. I guess a new review + approval is required. It does not treat live reload options as part of config anymore. They are calculated independently from other config in Before my rewrites of all that stuff live reload was calculated in This introduces inconsistency between both which may result in broken live reload support if CSP is put in meta tag. Especially the |
Squashed commits. |
Allowing connections and script source required by livereload feature was broken by configuration refactoring. This fixes it and adds tests.
This PR is based on #104. It should be merged afterwards.