feat: Build for production by default when making/packaging

`ember electron:make` and `ember electron:package` are much more similar to `ember electron:deploy` (which defaults to building for production) than they are to `ember electron:build` (which defaults to building for development). So this switches the default environment for those commands to `production`. Making or packaging is much more similar to
adopted-ember-addons · Nov 21, 2019 · 5484f6f · 5484f6f
1 parent ea7ff75
commit 5484f6f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/commands/make.js b/lib/commands/make.js
@@ -8,7 +8,7 @@ module.exports = BaseCommand.extend({
   description: 'Packages your Ember + Electron app into shippable installers',
 
   availableOptions: [
-    { name: 'environment',   type: String,  default: 'development', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }], description: 'Possible values are "development", "production", and "test".' },
+    { name: 'environment',   type: String,  default: 'production', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }], description: 'Possible values are "development", "production", and "test".' },
     { name: 'platform',      type: String,  aliases: ['p'] },
     { name: 'arch',          type: String,  aliases: ['a'] },
     { name: 'targets',       type: String,  aliases: ['t'], description: 'Override the build targets specified in your electron-forge config.' },

diff --git a/lib/commands/package.js b/lib/commands/package.js
@@ -8,7 +8,7 @@ module.exports = BaseCommand.extend({
   description: 'Builds & packages your Electron app',
 
   availableOptions: [
-    { name: 'environment', type: String, default: 'development', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }], description: 'Possible values are "development", "production", and "test".' },
+    { name: 'environment', type: String, default: 'production', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }], description: 'Possible values are "development", "production", and "test".' },
     { name: 'platform',    type: String, aliases: ['p'] },
     { name: 'arch',        type: String, aliases: ['a'] },
     { name: 'skip-build',  type: Boolean, aliases: ['s'], description: 'Skip the Ember build step and use an already-build from the output path.' },