Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix root-url for github pages #481

Merged
merged 1 commit into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
- name: Build
run: pnpm run build
working-directory: test-app
env:
GITHUB_PAGES: "true"
- name: Deploy
uses: peaceiris/actions-gh-pages@v4
if: github.ref == 'refs/heads/main'
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![npm version](https://badge.fury.io/js/ember-infinity.svg)](http://badge.fury.io/js/ember-infinity)
[![Ember Observer Score](http://emberobserver.com/badges/ember-infinity.svg)](http://emberobserver.com/addons/ember-infinity)

Demo: [ember-adopted-addons.github.io/ember-infinity/](https://ember-adopted-addons.github.io/ember-infinity/)
Demo: [adopted-ember-addons.github.io/ember-infinity/](https://adopted-ember-addons.github.io/ember-infinity/)

Simple, flexible infinite scrolling for Ember CLI Apps. Works out of the box
with the [Kaminari Gem](https://github.com/amatsuda/kaminari.git).
Expand Down Expand Up @@ -41,7 +41,7 @@ We test against `ember-source >= 3.28`. Try out `v2.0.0`. If it doesn't work or

2. **infinity-loader component**

3. **Route Mixin** (deprecated and removed as of 1.1). If you still want to upgrade, but keep your Route mixins, install `1.0.2`. See old docs (here)[https://github.com/ember-adopted-addons/ember-infinity/blob/2e0cb02e5845a97cad8783893cd7f4ddcf5dc5a7/README.md]
3. **Route Mixin** (deprecated and removed as of 1.1). If you still want to upgrade, but keep your Route mixins, install `1.0.2`. See old docs (here)[https://github.com/adopted-ember-addons/ember-infinity/blob/2e0cb02e5845a97cad8783893cd7f4ddcf5dc5a7/README.md]

### Service Component Approach

Expand Down
2 changes: 1 addition & 1 deletion test-app/config/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = function (environment) {
const ENV = {
modulePrefix: 'test-app',
environment,
rootURL: '/',
rootURL: process.env.GITHUB_PAGES ? '/ember-infinity/' : '/',
locationType: 'history',
EmberENV: {
EXTEND_PROTOTYPES: false,
Expand Down