Updated paper-switch component

[jorgelainfiesta]

Hi,

I'm opening this so you can start reviewing my changes. This is my first PR so I'd like to know if it's fine. I need help to test the Hammer.js behaviors on this component. I made some research on how to mock the gestures but still don't know what's the correct approach for the project.

Thanks,
Jorge L

[miguelcobain]

Instead of using jquery's css() and removeAttr() functions on .md-thumb-container, let's use a computed property that returns the style and bind it to the style attribute on the element like

<div class="md-thumb-container" style={{thumbContainerStyle}}>
  <!-- inner elements -->
</div>

[joukevandermaas]

if you do that, you have to return a SafeString from the computed and use triple curlies.

[miguelcobain]

Safestring yes, but you don't need triple curlies, unless you're printing any html? Please elaborate.

Example:

• https://github.com/miguelcobain/ember-paper/blob/wip/v1.0.0/addon%2Fcomponents%2Fpaper-progress-circular.js#L43-L49
• https://github.com/miguelcobain/ember-paper/blob/wip/v1.0.0/app%2Ftemplates%2Fcomponents%2Fpaper-progress-circular.hbs#L1

[jorgelainfiesta]

Thanks for the comments Miguel! I've done most of them, but I'm now dealing with issues that the changes created.

I was honestly lost in your conversation with Chris (runinspired) so I don't know what to do with Hamme now.

[jorgelainfiesta]

I made the changes but now the sliding is really unstable. Not sure of what's causing it. The tests pass because they don't test Hammer gestures.

[miguelcobain]

I'm stocked that jscs tests are passing here. You shouldn't be able to write const in functions.

[jorgelainfiesta]

I didn't know that. I actually rarely use let because most of the time I won't ever change the variable value.

[miguelcobain]

JSCS tests are failing because of: https://github.com/DockYard/ember-suave/issues/106#issuecomment-187720996

If JSCS tests were working you could not use const inside functions. Reasoning: http://madhatted.com/2016/1/25/let-it-be

Besides this, there are other style errors in this PR.
Too bad JSCS isn't working right now. :/

[jorgelainfiesta]

Thanks for the info. I'll definitely change it today.

[miguelcobain]

Please run jscs -c .jscsrc addon to see your jscs errors (after npm install -g jscs).
You might see other errors related with other files. Ignore them please for now.

[jorgelainfiesta]

I tried pulling wip/v1.0.0 and rebasing my branch to resolve conflicts but git says I'm up to date.

[jorgelainfiesta]

Hi @miguelcobain, have you guys decided how we'd handle the hammer stuff? or should I try another component?

[miguelcobain]

@jorgelainfiesta

1. you need to rebase your branch to reapply upstream commits to make this mergeable again
2. Let's use vanilla HammerJS for now. We can switch to an ember addon later when things are more clear.

HammerJS recognizes gestures. We use it to recognize the pan action to move the switch.
Notice that the original angular material code binds the gestures in different components than this branch.

[miguelcobain]

I've finished the above stuff. Thanks.

[jorgelainfiesta]

Sorry, thanks for fixing it. I totally messed up my repo trying to do the rebase, so I'd get some help from a friend by tomorrow. I'm glad it's merged now.