fix: recompute is-active on route changes #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, mind adding a test also? |
|
There's test coverage in my PR : #10 |
|
Should have checked the PRs 😸 |
|
@knownasilya the unresolved thing in the other PR is that the recomputing does not work for Maybe we could go forward so far with having this work only with the main |
|
I can copy your test over, does that sound good @MartinMalinda? |
|
Sure, or we can just merge that one. I don't see a big difference. |
|
I messed this up, I'm sorry @MartinMalinda / @knownasilya 😢. Should be fixed in #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rlivsey