Ensure all this.recompute calls are wrapped in a runloop
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is ready for a rebase now that #125 landed |
xg-wang
force-pushed
the
dom
branch
2 times, most recently
from
3089e45 to
ebcf501
Compare
|
@rwjblue rebased again |
|
Ugh, looks like more yarn.lock conflicts (maybe dependabot merges?), sorry @xg-wang |
Ember Helpers recompute doesn't initiate a runloop, it just marks the element to be dirty and waiting next runloop to start a new render transaction. By wrapping recompute in a runloop join we can force a "real" recompute. Fixing above issue unblocks upgrading ember-test-helper to >= 1.0.1.
|
@rwjblue Yeah dependabot merged another dep PR this morning |
|
whew, finally sorry about all that run around @xg-wang |
|
np, thank you for taking care of this! |
rwjblue
changed the title
this.recompute calls are wrapped in a runloop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember Helpers recompute doesn't initiate a runloop, it just marks the
element to be dirty and waiting next runloop to start a new render
transaction. By wrapping recompute in a runloop join we can force a
"real" recompute.
Fixing above issue unblocks upgrading ember-test-helper to >= 1.0.1.
Needs #125
References: