[Breaking change]

remove bindable form attribute, as it is considered a readOnly property on HTMLSelectElement https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement
adopted-ember-addons · May 20, 2015 · f0f3f28 · f0f3f28
1 parent 026b5d1
commit f0f3f28
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/addon/components/x-select.js b/addon/components/x-select.js
@@ -24,7 +24,7 @@ var isArray = Ember.isArray;
 export default Ember.Component.extend({
   tagName: "select",
   classNameBindings: [":x-select"],
-  attributeBindings: ['disabled', 'tabindex', 'multiple', 'name', 'autofocus', 'form', 'required', 'size'],
+  attributeBindings: ['disabled', 'tabindex', 'multiple', 'name', 'autofocus', 'required', 'size'],
 
   /**
    * Bound to the `disabled` attribute on the native <select> tag.

diff --git a/tests/acceptance/x-select-single-test.js b/tests/acceptance/x-select-single-test.js
@@ -96,9 +96,6 @@ describe('XSelect: Single Selection', function() {
     it('renders the name attribute', function() {
       expect(this.$().attr('name')).to.equal('person-select');
     });
-    it('renders the form attribute', function() {
-      expect(this.$().attr('form')).to.equal('person-form');
-    });
     it('renders the size attribute', function() {
       expect(this.$().attr('size')).to.equal('3');
     });