Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets repo #63

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Add secrets repo #63

merged 3 commits into from
Oct 14, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented Oct 14, 2024

Migrating https://github.com/AdoptOpenJDK/secrets to Adoptium, the end goal is to archive this repo and move everything to Bitwarden but for now it makes sense to keep it

Signed-off-by: George Adams <[email protected]>
@gdams gdams requested a review from a team as a code owner October 14, 2024 09:27
Copy link

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

Copy link

This comment has been minimized.

Signed-off-by: George Adams <[email protected]>

This comment has been minimized.

This comment has been minimized.

1 similar comment
Copy link

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

Signed-off-by: George Adams <[email protected]>
Copy link

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for 24190f9
Organization adoptium[id=adoptium]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

+  add repository[name="secrets"] {
+    allow_auto_merge                  = false
+    allow_forking                     = false
+    allow_merge_commit                = false
+    allow_rebase_merge                = true
+    allow_squash_merge                = true
+    allow_update_branch               = true
+    archived                          = false
+    auto_init                         = true
+    code_scanning_default_setup_enabled = false
+    custom_properties                 = {}
+    default_branch                    = "main"
+    delete_branch_on_merge            = true
+    dependabot_alerts_enabled         = true
+    description                       = "The Secrets Repo for Eclipse Adoptium"
+    gh_pages_build_type               = "disabled"
+    has_discussions                   = false
+    has_issues                        = true
+    has_projects                      = true
+    has_wiki                          = true
+    is_template                       = false
+    merge_commit_message              = "PR_TITLE"
+    merge_commit_title                = "MERGE_MESSAGE"
+    name                              = "secrets"
+    private                           = true
+    squash_merge_commit_message       = "COMMIT_MESSAGES"
+    squash_merge_commit_title         = "COMMIT_OR_PR_TITLE"
+    topics                            = []
+    web_commit_signoff_required       = false
+  }

+  add repo_workflow_settings[repository="secrets"] {
+    actions_can_approve_pull_request_reviews = true
+    enabled                           = true
+  }
  
  Plan: 2 to add, 0 to change, 0 to delete.

Copy link

This is your friendly self-service bot.
This Pull Request is eligible for auto-merging as it passed the following checks:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource

In order to automatically merge and apply the changes, add a comment /otterdog merge. 🚀

@gdams
Copy link
Member Author

gdams commented Oct 14, 2024

/otterdog merge

@eclipse-otterdog eclipse-otterdog bot merged commit 7216251 into adoptium:main Oct 14, 2024
2 checks passed
Copy link

This is your friendly self-service bot.

The changes could not be applied successfully, please check the output:

Organization adoptium[id=adoptium]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

+  add repository[name="secrets"] {
+    allow_auto_merge                  = false
+    allow_forking                     = false
+    allow_merge_commit                = false
+    allow_rebase_merge                = true
+    allow_squash_merge                = true
+    allow_update_branch               = true
+    archived                          = false
+    auto_init                         = true
+    code_scanning_default_setup_enabled = false
+    custom_properties                 = {}
+    default_branch                    = "main"
+    delete_branch_on_merge            = true
+    dependabot_alerts_enabled         = true
+    description                       = "The Secrets Repo for Eclipse Adoptium"
+    gh_pages_build_type               = "disabled"
+    has_discussions                   = false
+    has_issues                        = true
+    has_projects                      = true
+    has_wiki                          = true
+    is_template                       = false
+    merge_commit_message              = "PR_TITLE"
+    merge_commit_title                = "MERGE_MESSAGE"
+    name                              = "secrets"
+    private                           = true
+    squash_merge_commit_message       = "COMMIT_MESSAGES"
+    squash_merge_commit_title         = "COMMIT_OR_PR_TITLE"
+    topics                            = []
+    web_commit_signoff_required       = false
+  }
╷
│ Warning: Adding repository 'secrets' while the project 'adoptium' has no GitHub organization configured in the PMI.
│
│    Don't forget to add an entry for this repo to the list of GitHub repositories: 
│      https://github.com/adoptium/secrets
╵

+  add repo_workflow_settings[repository="secrets"] {
+    actions_can_approve_pull_request_reviews = true
+    enabled                           = true
+  }

  
  Applying changes:



╷
│ Error: failed to apply patch: ADD- repository[name="secrets"]
│
│    failed to update code scanning config for repo 'adoptium/secrets':
│    Exception while accessing http://api.github.com/repos/adoptium/secrets/code-scanning/default-setup: (status=403, body={"message":"Advanced Security must be enabled for this repository to use code scanning.","documentation_url":"https://docs.github.com/rest/code-scanning/code-scanning#update-a-code-scanning-default-setup-configuration","status":"403"})
╵
  Done.
  
  Executed plan: 2 added, 0 changed, 0 deleted.

cc @adoptium/eclipsefdn-security

cc @adoptium/eclipsefdn-releng

@netomi
Copy link
Contributor

netomi commented Oct 14, 2024

is this repo associated with the adoptium or temurin project?

@netomi
Copy link
Contributor

netomi commented Oct 14, 2024

I added it now to the adoptium project, let me know if this is wrong, this is also how the eclipse_project property is setup atm.

@netomi
Copy link
Contributor

netomi commented Oct 14, 2024

/otterdog done

Copy link

This is your friendly self-service bot. The PR has been marked as being completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants