-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added system test pre-stage jars #533
Conversation
5242093
to
7a1d0ca
Compare
scripts/getDependencies.pl
Outdated
mauve => { | ||
url => 'https://ci.adoptium.net/job/systemtest.getDependency/lastSuccessfulBuild/artifact/systemtest_prereqs/mauve/mauve.jar', | ||
fname => 'mauve.jar', | ||
sha1 => '8ed5b172be6a8885b72d0015f44e2a0b6c172d47' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
systemtest.getDependency builds mauve. The sha1 will be different in every build. We will need to ignore the sha1. The same as tools.
we do not need to ignore checksum for all systemtests jars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has not been addressed.
We should not ignore checksum for all systemtests jars. It means line 329 my $ignoreChecksum = ($url =~ /systemtest.getDependency/);
is wrong. Using mauve
as an example, it should not have sha1
. And we should update the logic to if sha1
or shaurl
does not exist, ignore checksum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llxia I have updated the line to address the logic to if sha1 or shaurl does not exist, ignore checksum as below.
my $ignoreChecksum = (!defined $sha1 || $sha1 eq '') && (!defined $shaurl || $shaurl eq '');
.
7a1d0ca
to
8d3c4a9
Compare
30ac418
to
dc21e7b
Compare
054cf64
to
7681dcc
Compare
f046b76
to
134e3fd
Compare
- Enables to avoid system test prerequisite zip file being empty. related: adoptium/aqa-tests#4912 Signed-off-by: Anna Babu Palathingal <[email protected]>
134e3fd
to
1103c70
Compare
Note: pre-stage system test jars in a separate folder are a temporary solution. Eventually, all jars will be moved into the same dir and duplicate jars will be removed. See adoptium/aqa-tests#4912 (comment) |
Noticed in the job console that SysinternalsSuite.zip is downloaded at the runtimes and moved into
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related: adoptium/aqa-tests#4912