Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What exactly is a build number? #163

Closed
tushev opened this issue Aug 14, 2020 · 9 comments
Closed

What exactly is a build number? #163

tushev opened this issue Aug 14, 2020 · 9 comments
Labels
question Further information is requested
Milestone

Comments

@tushev
Copy link

tushev commented Aug 14, 2020

I have questions about build number - 11.0.8 +10 :

  1. What exactly is a build number? What changes in between builds?

  2. As far as I understand, if something significant changes, then minor or security version is being changed. So I suppose that the build number is safe to ignore - is this correct?

@aahlenst
Copy link
Contributor

aahlenst commented Aug 14, 2020

Commits are being added by OpenJDK between build numbers. But once released (ga tag), it is unusual for this number to be increased. Normally, the patch segment (8 in the sample you provided) is increased. Still, it seems a bit dangerous to ignore the build number.

@aahlenst aahlenst added the question Further information is requested label Aug 14, 2020
@tushev
Copy link
Author

tushev commented Aug 14, 2020

Thanks! I mean, is it safe for an end-user to update only when some greater number (i.e. security) changes? So it is not necessary to update, say from 11.0.8+10 to 11.0.8+11 if this happens for some reason?

@aahlenst
Copy link
Contributor

If this happens and reaches the end user, then they should update. It isn't cosmetic stuff that would be changed at that stage.

@tushev
Copy link
Author

tushev commented Aug 14, 2020

OK.

Is there a way to get build from, say, release file or you have to run java -version and parse it?

@aahlenst
Copy link
Contributor

It's in the registry. See your old post: #155 (comment). There it says 11.0.8.10 which is 11.0.8+10.

@tushev
Copy link
Author

tushev commented Aug 14, 2020

Thanks! My goal is to robustly detect version not only for MSI's, but for ZIP-extracted instances as well.

I think I will then stick to registry, and use java -version for installations that are absent in the registry (although executing a shell command is much slower than parsing release file).

@aahlenst
Copy link
Contributor

aahlenst commented Aug 14, 2020

It's gross to parse that over and over again. As you can see in https://github.com/AdoptOpenJDK/openjdk15-binaries/releases/tag/jdk15u-2020-08-14-15-52, there are JSON files next to each package with metadata. What about opening an issue in https://github.com/AdoptOpenJDK/openjdk-build that we place more info in the tarballs themselves? Do you have a release file handy? I don't remember what's in it.

@tushev
Copy link
Author

tushev commented Aug 14, 2020

These files vary from version to version. In case of 11 branch, they look like:
release.txt

I think it will be a good idea to add more info in it.

@aahlenst
Copy link
Contributor

I think the question was answered.

@karianna karianna added this to the August 2020 milestone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants