Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full version info (with build number) to RELEASE file #2034

Closed
tushev opened this issue Aug 14, 2020 · 2 comments
Closed

Add full version info (with build number) to RELEASE file #2034

tushev opened this issue Aug 14, 2020 · 2 comments
Labels
bug Issues that are problems in the code as reported by the community

Comments

@tushev
Copy link

tushev commented Aug 14, 2020

Hello,

It turns out that release file at the root of the installation lacks build number info.

Currently we have only Major.Minor.Security, and not +Build, although +Build can be important (adoptium/adoptium-support#163).

For instance, if I want to determine full release version, like 11.0.8+10, I currently have to query windows registry to get that '+10' (in case of windows) or run java -version and parse its output (which is kinda slow if I'm going multiple installations) in case installation was extracted from ZIP, and not MSI.

I suggest adding something like SEMVER = "11.0.8+10" to release file so It will be possible to get all version info from there.

Additionally, it would be great to have something about hotspot/openj9 (and openj9 heap size) in release as well without having to dig through the filesystem (adoptium/adoptium-support#153).

@karianna karianna added the bug Issues that are problems in the code as reported by the community label Aug 18, 2020
@austin0
Copy link
Contributor

austin0 commented Aug 24, 2020

The contents of the release file is almost entirely decided within the OpenJDK being built, this is why jdk8u/11u+ differ greatly in their contents, so adding new values might not be as clean as initially expected.

Currently --with-vendor-version-string / IMPLEMENTOR_VERSION is set to always be AdoptOpenJDK and could be easily changed to contain the full version+build number. However, this parameter only exists for jdk9+ so jdk8u would still need a separate patch.

Solution following this is to add a new section to the build scripts that adds values to the release file, this way adoptium/adoptium-support#153, adoptium/adoptium-support#163, and any future requests could be accommodated. Tagging @sxa on if this is a good/bad idea and for any info on why --with-vendor-version-string is set to a static AdoptOpenJDK.

@austin0
Copy link
Contributor

austin0 commented Sep 11, 2020

Closing as #2049 has been merged.

@austin0 austin0 closed this as completed Sep 11, 2020
@karianna karianna added this to the September 2020 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community
Projects
None yet
Development

No branches or pull requests

3 participants