Update build retry logic #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying a build, TRSS will retry 3 times. In the case of an error, the build will move back to the queue if the return code from Jenkins API is not 404. If the return code is 404, x-jenkins header is checked to ensure the error code is from Jenkins (not nginx). In this case, it means the build has an invalid url or is expired. retry function returns 404 and TRSS will stop processing this build. Otherwise, the error will be ignored (network issue) and the build will move back to the queue. return code 404 only if the Jenkins server returns 404 for the build (i.e., invalid url, expired build, etc) - sleep is removed to increase efficiency and reliability. We will check the header in the response to determine the invalid/expired build case. - test API getJenkinsBuildInfo is added - fix log issue related: adoptium#852 Signed-off-by: Lan Xia <[email protected]>
|
This is the server change and it is tested locally. |
✅ Deploy Preview for eclipsefdn-adoptium-trss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
smlambert
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying a build, TRSS will retry 3 times.
In the case of an error, the build will move back to the queue if the return code from Jenkins API is not 404.
If the return code is 404, x-jenkins header is checked to ensure the error code is from Jenkins (not nginx).
In this case, it means the build has an invalid url or is expired. retry function returns 404 and TRSS will stop processing this build.
Otherwise, the error will be ignored (network issue) and the build will move back to the queue.
related: #852