Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude 2 jfr testcases on aarch64 platform #2999

Closed
wants to merge 3 commits into from
Closed

Exclude 2 jfr testcases on aarch64 platform #2999

wants to merge 3 commits into from

Conversation

sainamercy
Copy link
Contributor

@sainamercy sainamercy commented Oct 14, 2021

Related to issue #2985

@smlambert smlambert changed the title Exclude 2 jfr testcases on aarch64 platfoam Exclude 2 jfr testcases on aarch64 platform Oct 14, 2021
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sainamercy - I will run some tests to verify this PR excludes the 2 testcases on that platform. In the meantime you can push a change to remove the change to the .md file and otherwise this PR looks good.

Contributing.md Outdated
Comment on lines 11 to 12
Sainamercy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this change, it is not needed at our project (as we keep track of contributions via github metrics and ECA validation).

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainamercy - I did not mean for you to delete the entire Contributing.md file, I just meant for you to remove the 2 lines you added to it (a blank line and a line with your name on it). You will need to add the Contributing.md file back.

@sainamercy
Copy link
Contributor Author

sainamercy commented Oct 14, 2021

@smlambert Yeah, I noticed, I am still learning to maneuver around

@sophia-guo
Copy link
Contributor

And could you please sign up the ECA with the same email as your github email. https://www.eclipse.org/legal/ECA.php ?@sainamercy

@sainamercy
Copy link
Contributor Author

@sophia-guo I used the same email, the error arose when I deleted Contributing.md file. I am working on it

@sainamercy sainamercy closed this Oct 15, 2021
@sainamercy sainamercy deleted the Exclude-2-jfr-testcases-on-aarch64-platfoam branch October 16, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants