Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude 2 jfr testcases on aarch64 platform #3007

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Exclude 2 jfr testcases on aarch64 platform #3007

merged 3 commits into from
Oct 15, 2021

Conversation

sainamercy
Copy link
Contributor

@sainamercy sainamercy commented Oct 15, 2021 •
edited
Loading

Related to issue #2985

smlambert
smlambert reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good @sainamercy, thank you! I will run a few tests to verify it, and then complete the review!

sophia-guo
sophia-guo approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert
Copy link
Contributor

Testing via: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1710/

smlambert
smlambert approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sainamercy !

@smlambert smlambert merged commit 7f0f521 into adoptium:master Oct 15, 2021
@sainamercy
Copy link
Contributor Author

Thanks @smlambert @sophia-guo

This was referenced Jan 20, 2022
Closed
Open
@sainamercy sainamercy deleted the Exclude-2-jfr-testcases-on-aarch64-platform branch February 27, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@sophia-guo sophia-guo sophia-guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sainamercy @smlambert @sophia-guo