Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azul specific ProblemList file #3723

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Add azul specific ProblemList file #3723

merged 2 commits into from
Jun 7, 2022

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jun 2, 2022 •
edited
Loading

  • add azul jdk8 problem list file
  • add empty azul other version problemlist file
  • add redhat jdk18 and jdk19 problemlist files( exact same as jdk17 as the initial version)
  • remove the jdk_vendor parameter from jenkins

Related #2826

Signed-off-by: Sophia Guo [email protected]

@sophia-guo sophia-guo marked this pull request as draft June 2, 2022 20:16
@sophia-guo sophia-guo force-pushed the azul branch 7 times, most recently from aff7c71 to f2a54e7 Compare June 6, 2022 14:33
@smlambert smlambert mentioned this pull request Jun 6, 2022
Closed
@sophia-guo
Add other version of empty problem list file as placeholder
19c3000 
Otherwise job will fail due to non-exist files.

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo
Copy link
Contributor Author

depends adoptium/TKG#327

Grinder: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4944/console

JDK_VENDOR removed grinder: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4945/

@sophia-guo sophia-guo marked this pull request as ready for review June 6, 2022 15:59
@sophia-guo sophia-guo requested review from smlambert and llxia June 6, 2022 16:00
llxia
llxia approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo sophia-guo self-assigned this Jun 7, 2022
smlambert
smlambert approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

openjdk/excludes/vendors/azul/ProblemList_openjdk8.txt
############################################################################

# hotspot_jre
runtime/containers/docker/TestMemoryAwareness.java https://bugs.openjdk.java.net/browse/JDK-8229182 generic-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we simply change the shared ProblemList file? https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk8.txt#L125 to be generic-all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status of https://bugs.openjdk.org/browse/JDK-8229182 is fixed. And it only happened to specific platforms for temurin. That's why I didn't move it to the shared problemlist. Should we just move it to the shared problemlist in case it may happen to other platforms?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then let's just leave as is and merge it as it is for now 👍

@smlambert
Copy link
Contributor

smlambert commented Jun 7, 2022 •
edited
Loading

@sophia-guo - 2 approvals, but I am not merging it, in case you wanted to move the exclude for TestMemoryAwareness to the shared problemlist as per the review comment. Leave you to merge when you want.

@smlambert smlambert merged commit a883d85 into adoptium:master Jun 7, 2022
sophia-guo added a commit to sophia-guo/openjdk-tests that referenced this pull request Jun 8, 2022
@sophia-guo
Add azul specific ProblemList file (adoptium#3723)
4283a2e 
* Exclude azul ProblemList file



* Add other version of empty problem list file as placeholder

Otherwise job will fail due to non-exist files.

Signed-off-by: Sophia Guo <[email protected]>
# Conflicts:
#	openjdk/openjdk.mk
@sophia-guo sophia-guo mentioned this pull request Jun 8, 2022
Merged
smlambert added a commit that referenced this pull request Jun 8, 2022
@sophia-guo @smlambert
@karianna @sendaoYan
(v0.9.1-release): support vendor specific problem list files (#3743)
6017727 
* Exclude TestShutdownEvent for all platforms (#3707)

Signed-off-by: Shelley Lambert <[email protected]>

* Add azul specific ProblemList file (#3723)

* Exclude azul ProblemList file



* Add other version of empty problem list file as placeholder

Otherwise job will fail due to non-exist files.

Signed-off-by: Sophia Guo <[email protected]>
# Conflicts:
#	openjdk/openjdk.mk

* Add Alibaba problem lists (#3740)

* Add Alibaba problem lists

Signed-off-by: Sophia Guo <[email protected]>

* Update openjdk/excludes/vendors/alibaba/ProblemList_openjdk11.txt

Co-authored-by: yansendao <[email protected]>

Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: yansendao <[email protected]>

Co-authored-by: Shelley Lambert <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: yansendao <[email protected]>
@sophia-guo sophia-guo mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@llxia llxia llxia approved these changes

Assignees

@sophia-guo sophia-guo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophia-guo @smlambert @llxia