Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude FFI related test suite in JDK19 #3824

Merged

Conversation

ChengJin01
Copy link

The change is to exclude the real test cases in
ImplicitAttach which is enabled via AttachTest.

Signed-off-by: Cheng Jin [email protected]

@ChengJin01
Copy link
Author

The PR replaces AttachTest with ImplicitAttach to correct the issue detected at eclipse-openj9/openj9#15466 (comment) due to the PR previously merged at #3815.

Reviewer: @llxia
FYI: @Mesbah-Alam, @ShelleyLambert

@ChengJin01
Copy link
Author

ChengJin01 commented Jul 5, 2022

Hi @llxia, this PR needs to run Jenkins/Grinder test on the failing tests to ensure the failing tests specific to ImplicitAttach are excluded.

@llxia
Copy link
Contributor

llxia commented Jul 5, 2022

https://openj9-jenkins.osuosl.org/job/Grinder/1095

The change is to exclude the real test cases in
ImplicitAttach which is enabled via AttachTest.

Signed-off-by: Cheng Jin <[email protected]>
@ChengJin01 ChengJin01 force-pushed the exclude_ffi_tests_ImplicitAttach_jdk19 branch from 45ea06a to 9fe1eb5 Compare July 6, 2022 01:10
@ChengJin01
Copy link
Author

@llxia, the Grinder above didn't make it and still ended up with the same failure. So I just updated the exclude test with java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1. Please run the Grinder again to see how it goes.

@llxia
Copy link
Contributor

llxia commented Jul 6, 2022

@ChengJin01
Copy link
Author

The failing test was successfully excluded in the Grinder above at https://openj9-jenkins.osuosl.org/job/Grinder/1096/testReport/.

Package	                                                                      Duration	Fail	(diff)	Skip	(diff)	Pass	(diff)	Total	(diff)
java/lang/Thread/jni/AttachCurrentThread/AttachTest	1.3 sec	    0	   -1	                 0		  1		        1	-1

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit e7dbe23 into adoptium:master Jul 6, 2022
@zdtsw zdtsw mentioned this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants