Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDK17 to use jtreg7.3.1.1 #4852

Closed
wants to merge 1 commit into from

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Nov 3, 2023

This updates the logic in openjdk/build.xml file to change JDK17 to use jtreg7.3.1.1
closes #4851
Signed-off-by: Anna Babu Palathingal [email protected]

This updates the logic in openjdk/build.xml file to include JDK17 to use jtreg7.3.1.1

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor Author

annaibm commented Nov 3, 2023

GRINDER TESTS
1.BUILD_LIST: openjdk,
TARGET: jdk_math,
JDK_VERSION: 17,
TEST OUTPUT: 35817
2. BUILD_LIST: openjdk,
TARGET: jdk_math,
JDK_VERSION: 11,
TEST OUTPUT:35818

@annaibm annaibm marked this pull request as ready for review November 3, 2023 17:26
@llxia
Copy link
Contributor

llxia commented Nov 3, 2023

Thanks @annaibm . I see 17.0.9-internal is used in Grinder. Can you try to run with 17.0.10-internal?
Also, in the PR description, please use a keyword so that the related issue can be closed automatically. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@llxia
Copy link
Contributor

llxia commented Nov 3, 2023

Grinder works as expected. jtreg_7_3_1_1 is used for JDK17.

00:01:49.607  getDependentLibs:
00:01:50.038       [exec] --------------------------------------------
00:01:50.038       [exec] path is set to /home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/lib
00:01:50.038       [exec] task is set to default
00:01:50.038       [exec] dependencyList is set to jtreg_7_3_1_1,tohandler_simple

However, the PR build does not pick up the change. jtreg_6_1 is used for JDK17.
https://github.com/adoptium/aqa-tests/actions/runs/6748416466/job/18346700001?pr=4852

getDependentLibs:
     [exec] --------------------------------------------
     [exec] path is set to /home/runner/work/aqa-tests/aqa-tests/aqa-tests/TKG/../TKG/lib
     [exec] task is set to default
     [exec] dependencyList is set to jtreg_6_1

adoptium master is used in the PR builds. @sophia-guo do you know why this is happening?

git repo: 
  Fetch URL: https://github.com/adoptium/aqa-tests.git
sha:
e730d4fc4a6bd2367f697ee246d26d128fc85e28

@llxia
Copy link
Contributor

llxia commented Nov 3, 2023

issue is created: #4855

@llxia
Copy link
Contributor

llxia commented Nov 3, 2023

Close the PR. In favor of #4853

@llxia llxia closed this Nov 3, 2023
@annaibm annaibm deleted the Update_JDK17_JTREG branch November 6, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing on jdk-17.0.10+1 requires jtreg version 7.3.1 b1 or higher
2 participants