-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jcstress version #5270
Update jcstress version #5270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, a nice refactor later on might be to have the version string passed in as a variable.
Enhancement issue is opened at adoptium/TKG#541 |
Hello! I had filled and am working on #5261 is it related or is it just coincidence? Thanx for doing this! |
adoptium/TKG#541 is an enhancement for easy maintenance in the future. jar version should not be in the fname. In this way, we do not need to update references for any jctress.jar upgrades. |
Right! I wanted to follow the jtreg principle, where the getDepndencies will resolve best jcstress-xyz.jar for given jdk/variant, and provide that via variable and/or will provie it simply as jctress.jar. Well the same as jtreg.jar setup is doing. Or am I on completly wrong track? |
Actually there is a missing step. IIRC, quite a lot fo new targets were added beten 2022 and 2024, @Luigi96 Had you tried that what targets are not run ? |
For jtreg, we need to run different versions of jtreg.jar based on the JDK version, and special unzipping is needed. Are these needed for jcstress jar? From what I can see, we just reference the jcstress.jar directly. |
Ifaik not yet. But soon the bytecode level will be hit, and for jdk8 will be needed different jcstress then for newer jdk. |
|
Should I draft PR, or will somebody else doing it? |
Update Jcstress version to match dependency update on TKG - #515