problemList: add missing windows-aarch64 exclusions #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llxia
approved these changes
Oct 23, 2024
gdams
force-pushed
the
problemlist
branch
2 times, most recently
from
ed14982 to
8fc4afb
Compare
llxia
reviewed
Oct 23, 2024
| @@ -382,6 +385,10 @@ compiler/codegen/aes/TestAESMain.java https://github.com/adoptium/aqa-tests/issu | |||
|
|
|||
| # jdk_jfr | |||
|
|
|||
| jdk/jfr/event/runtime/TestDumpReason.java https://github.com/adoptium/aqa-tests/issues/4155 | |||
| jdk/jfr/event/runtime/TestShutdownEvent.java https://github.com/adoptium/aqa-tests/issues/4155 | |||
| jdk/jfr/jvm/TestDumpOnCrash.java https://github.com/adoptium/aqa-tests/issues/4155 | |||
There was a problem hiding this comment.
There is no platform specified
There was a problem hiding this comment.
updated PTAL, I wasn't sure if I should remove these excludes from the Microsoft vendor problemList or not?
There was a problem hiding this comment.
These excludes should be removed from the Microsoft vendor problemList. There is no need to duplicate them. openjdk/excludes/ProblemList_openjdkxxx.txt applies to JDK_IMPL=hotspot (regardless of vendor).
There was a problem hiding this comment.
I've removed the duplicated excludes from the Msft vendor folder
llxia
approved these changes
Oct 24, 2024
smlambert
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most of these are defined in #4155 (comment)
Grinder: https://ci.adoptium.net/job/Grinder/11258/