Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making jdk for jtreg build explicit #1019

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

judovana
Copy link
Contributor

and so imune against change of system jdk on underlying system/image

and so imune against change of system jdk on underlying system/image
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@judovana
Copy link
Contributor Author

This should fix the currently broken codetools - eg https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/1155/

It seesm that system jdk changed on that underlying system, and so old jtregs, were pulling to fresh jdk.

I'm a bit concerned about export PATH=$PATH:$JAVA_HOME/bin becasue it is done in method, and that method is called several times, so at the end , there is $PATH:$JAVA_HOME1/bin:$JAVA_HOME2/bin...:$JAVA_HOMEn/bin .. which do not seem correct.

I will add a commits on this topic, but first let ssee if it fixes it.

judovana and others added 3 commits April 24, 2024 18:17
Also put the "expected" java into the start, as otherwise the system JDK
would be always before the "expected" jdk. I think the meddling wiht
PATH is actually useless, but I do not see to the bottom of this script.
Am in temptation to remove that at all. But that can bite
@sophia-guo sophia-guo merged commit 2000dc4 into adoptium:master Apr 25, 2024
5 checks passed
@sophia-guo
Copy link
Contributor

@judovana
Copy link
Contributor Author

cool! ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants