Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass JDK_VERSIONS to smoke test parameters #203

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented Oct 8, 2021

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@gdams gdams marked this pull request as ready for review October 8, 2021 13:28
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious as to where 17 came from in the existing pipelines, but assuming there's a good reason why this now needs to be passed in I'm ok with it :-)

@gdams
Copy link
Member Author

gdams commented Oct 8, 2021

I'm curious as to where 17 came from in the existing pipelines, but assuming there's a good reason why this now needs to be passed in I'm ok with it :-)

So the smoke test job is only created if it didn't already exist. Because the jdk build used to produce JDK17 (until a few months ago), the generated jobs were set with JDK_VERSION as jdk17.

@github-actions github-actions bot added hotspot linux x64 Issues that affect or relate to the x64/x32 LINUX OS labels Oct 8, 2021
@gdams gdams merged commit 0d10b23 into master Oct 8, 2021
@gdams gdams deleted the gdams-patch-1 branch October 8, 2021 13:50
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot jenkins-pipeline linux testing x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Settled JDK version does not match" in JDK18 smoke tests
3 participants