Cherry pick 4d6f5e2 62da3c0 #691
Conversation
…m#681) Signed-off-by: Sophia Guo <[email protected]>
Block aqa and tck tests if smoke tests fail or are unstable. (adoptium#681) Copy downstream test jobs' Tap files no matter test jobs' result (adoptium#687) Signed-off-by: Sophia Guo <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
|
Not related with this PR: I can see even if it shows two reviewers pending I'm still allowed to merge it. It's not blocked by reviews, which seems not correct for me. |
|
Ya, we had that same issue in aqa-tests repository and had to raise an EF gitlab ticket to get the Github setting changed to require at least 1 review for merging into branches. (Once we start trialing the "OtterDog" application, we should gain some control and visibility back to view these kinds of settings, which for now are only visible to Eclipse Foundation admins. |
|
@smlambert want me to merge this? |
Block aqa and tck tests if smoke tests fail or are unstable. (#681)
Copy downstream test jobs' Tap files no matter test jobs' result (#687 )
Signed-off-by: Sophia Guo [email protected]