Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenJ9: Disable dtrace on jdk17 plinux #711

Merged
merged 3 commits into from
Jun 6, 2023
Merged

OpenJ9: Disable dtrace on jdk17 plinux #711

merged 3 commits into from
Jun 6, 2023

Conversation

AdamBrousseau
Copy link
Contributor

@AdamBrousseau AdamBrousseau commented Jun 1, 2023 •
edited
Loading

Depends #710 since both PRs touch the same line.

@AdamBrousseau
OpenJ9: Remove explicit jitserver enable option
d2e333d 
Is enabled by default on x/p/z linux in all versions
Related ibmruntimes#132

Signed-off-by: Adam Brousseau <[email protected]>
@AdamBrousseau
OpenJ9: Disable dtrace on jdk17 plinux
723f373 
Related adoptium#704

Signed-off-by: Adam Brousseau <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@AdamBrousseau AdamBrousseau changed the title Dtrace plinux jdk17 disable OpenJ9: Disable dtrace on jdk17 plinux Jun 2, 2023
adamfarley
adamfarley approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa sxa merged commit b3ad946 into adoptium:master Jun 6, 2023
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
@AdamBrousseau @sxa @luhenry
OpenJ9: Disable dtrace on jdk17 plinux (adoptium#711)
fc3d34a 
* OpenJ9: Remove explicit jitserver enable option

Is enabled by default on x/p/z linux in all versions
Related ibmruntimes#132

Signed-off-by: Adam Brousseau <[email protected]>

* OpenJ9: Disable dtrace on jdk17 plinux

Related adoptium#704

Signed-off-by: Adam Brousseau <[email protected]>

---------

Signed-off-by: Adam Brousseau <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@adamfarley adamfarley adamfarley approved these changes

Assignees
No one assigned
Labels
jenkins-pipeline linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdamBrousseau @karianna @adamfarley @sxa