Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v20204.04+01] Remove jdk22 pipelines as top level pipelines prefer these to 22u #996

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Apr 8, 2024

When I added jdk22u configurations I did not remove the jdk22 ones. This appears to have the unfortunate effect of resulting in the top level *_openjdk22-pipelines kicking off jdk22 jobs instead of jdk22u there run from the wrong repository and cannot pick up the correct tags.

Ref logic in

configPath = "${WORKSPACE}/${ADOPT_DEFAULTS_JSON['configDirectories']['build']}/${javaToBuild}_pipeline_config.groovy"

This PR removes the jdk22 files so that the logic referenced above selects the jdk22u repository

@sxa sxa self-assigned this Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sxa sxa changed the title Remove jdk22 pipelines as top level pipelines prefer these to 22u [v20204.04+01] Remove jdk22 pipelines as top level pipelines prefer these to 22u Apr 8, 2024
@sxa sxa requested a review from steelhead31 April 8, 2024 14:26
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sxa sxa merged commit 0bfc528 into adoptium:v2024.04+01 Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants