Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Playbook Java installation API broken #882

Closed
HusainYusufali opened this issue Aug 6, 2019 · 1 comment · Fixed by #895
Closed

Windows Playbook Java installation API broken #882

HusainYusufali opened this issue Aug 6, 2019 · 1 comment · Fixed by #895

Comments

@HusainYusufali
Copy link
Contributor

HusainYusufali commented Aug 6, 2019

The Windows playbook roles that install the OpenJ9 Java doesn't work because it produces multiple zip files because of the new large heap binary. Adding heap_size variable to the URL should fix this.

"OpenJDK8U-jdk_x64_windows_openj9_8u222b10_openj9-0.15.1.zip", "heap_size": "normal"
"OpenJDK8U-jdk_x64_windows_openj9_windowsXL_8u222b10_openj9-0.15.1.zip", "heap_size": "large"

The affected roles are Java8, Java11, and Java12.

Not sure what the default should be, but it can be added to AdoptOpenJDK_Windows_Playbook/group_vars/all/adoptopenjdk_variables.yml.

@sxa
Copy link
Member

sxa commented Aug 6, 2019

We generally use the hotspot ones at AdoptOpenJDK so this isn't an issue, but we don't have any particular need for the large heap ones to my knowledge so I'd pick normal for any PR on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants