Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heap size variable for Windows playbook #895

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Add heap size variable for Windows playbook #895

merged 1 commit into from
Aug 16, 2019

Conversation

HusainYusufali
Copy link
Contributor

@karianna karianna added this to the August 2019 milestone Aug 13, 2019
@karianna karianna requested a review from sxa August 13, 2019 21:39
@sxa
Copy link
Member

sxa commented Aug 14, 2019

I don't have a particular issue with this, but is there an issue that this is a solution to? When would you need to choose the large heap variant?

@HusainYusufali
Copy link
Contributor Author

This is so the when installing OpenJ9 variants it doesn't provide multiple variants and fail the playbook. We don't need to have heapsize the variable. I can just make it normal and remove the heapsize variable

@sxa
Copy link
Member

sxa commented Aug 15, 2019

No I'm happy with that. I'll hold off on merging it until @Willsparker has a chance to test it though as it'll be useful to have a windows PR to test something he's working on for me ;-)

@Willsparker
Copy link
Contributor

Tested on a Windows Server 2012 Vagrant VM and it's all good 👍

@karianna karianna merged commit c81eb05 into adoptium:master Aug 16, 2019
@HusainYusufali HusainYusufali deleted the java_heap_fix branch September 12, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Playbook Java installation API broken
4 participants