Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winPB: Fix broken Visual Studio 2013 role to use local installation media #2740

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Sep 12, 2022

Update the VS2013 role to work from local installation media.
This is only required until VS2013 is no longer used.
Fixes #2178

Checklist

@steelhead31 steelhead31 marked this pull request as ready for review September 12, 2022 08:31
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steelhead31 steelhead31 requested a review from sxa September 23, 2022 13:52
@steelhead31
Copy link
Contributor Author

@sxa, would you mind reviewing this PR. Thanks.

@sxa
Copy link
Member

sxa commented Oct 3, 2022

@steelhead31 Have you got a VPC run with this PR?

@steelhead31
Copy link
Contributor Author

steelhead31 commented Oct 3, 2022

@steelhead31 Have you got a VPC run with this PR?

I've started a new one here.. https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/1552/ ( required a second one, as the 7zip download task was broken, so I've fixed that too.. )

@steelhead31
Copy link
Contributor Author

@sxa, the VPC run built ok, there appears to be an issue with the tests, but that isnt related.

@sxa
Copy link
Member

sxa commented Oct 4, 2022

Yuk ... As you say:

22:46:27 mv: target '/home/vagrant' is not a directory
22:46:27 find: '/home/vagrant': No such file or directory
22:46:27 C:/vagrant/pbTestScripts/testJDKWin.sh: line 9: cd: /home/vagrant: No such file or directory
22:46:27 Cloning into 'openjdk-tests'...
22:46:27 Updating files:  30% (495/1635)
[...]
Updating files: 100% (1635/1635), done.
22:46:43 Invalid option: -t
22:46:47 C:/vagrant/pbTestScripts/testJDKWin.sh: line 24: cd: TKG: No such file or directory
22:46:47 make: *** No rule to make target '_extended.system'.  Stop.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

This could cause problems if people don't have the Vendor_Files directory with the file in it, so perhaps we should adjust the recommended commands in the docs to say that users skip MSVS_2013 by default too. Approving whether this is done here or separately :-)

@github-actions github-actions bot added the doc label Oct 4, 2022
@steelhead31 steelhead31 merged commit 641d8cf into adoptium:master Oct 4, 2022
@steelhead31 steelhead31 deleted the fix_issue_2178 branch October 4, 2022 12:28
@steelhead31 steelhead31 self-assigned this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Ansible request to fix MSVS_2013 broken installation
3 participants