-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winPB: Fix broken Visual Studio 2013 role to use local installation media #2740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sxa, would you mind reviewing this PR. Thanks. |
@steelhead31 Have you got a VPC run with this PR? |
I've started a new one here.. https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/1552/ ( required a second one, as the 7zip download task was broken, so I've fixed that too.. ) |
@sxa, the VPC run built ok, there appears to be an issue with the tests, but that isnt related. |
Yuk ... As you say:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
This could cause problems if people don't have the Vendor_Files directory with the file in it, so perhaps we should adjust the recommended commands in the docs to say that users skip MSVS_2013
by default too. Approving whether this is done here or separately :-)
Update the VS2013 role to work from local installation media.
This is only required until VS2013 is no longer used.
Fixes #2178
Checklist