MSI-Installer: Text is cut off and not readable

[larsen0815]

Please provide a brief summary of the bug

The help text for at least one element that can be installed is cut off (notice the "...").

Please provide steps to reproduce where possible

• On Windows, start the installer for Temurin JDK 17
• Continue until the page where it is possible to select elements to be installed
• Select "JavaSoft (Oracle) registry keys"
• See text on the right

Expected Results

Text should be short enough to be fully readable. Or better: Provide a link to a web page that has more information.

Actual Results

Text is cut off (to be precise: something is left out from the middle) and in this form makes no sense at all.

What Java Version are you using?

17

What is your operating system and platform?

No response

How did you install Java?

No response

Did it work before?

No response

Did you test with the latest update version?

No response

Did you test with other Java versions?

No response

Relevant log output

No response

[larsen0815]

Using the program "textify", I got this. A little bit too long... Dialog is not resizable.

Overwrites the reg keys HKLM\Software\JavaSoft (Oracle). After uninstallation of Eclipse Temurin, Oracle Java running from PATH "C:\Program Files (x86)\Common Files\Oracle\Java\javapath" does not work. You need to reinstall it to recreate these registry keys

[karianna]

@gdams - one for the Wix 4 rewrite.

[douph1]

As noted here

installer/wix/Lang/OpenJDK.Base.fr-fr.wxl.template

Line 19 in ce1b485

<!-- ! Description limité à 255 charactères -->

Description must be limited to 255 chars (spec that I found somewhere one time) .

This one on en-us is 258 chars after substituting {vendor_branding}) by "Eclipse Temurin"
In fr-fr around 256 with {vendor_branding}) replaced by "Eclipse Temurin"

I think I remember that the full text is show when the cursor go in top of the text.

Feel free to propose a shorter description for each language to fit into 255 chars

[adipiciu]

There is even a validation warning when building the msi:
warning SMOK1076 : ICE03: String overflow (greater than length permitted in column); Table: Feature, Column: Description, Key(s): FeatureOracleJavaSoft

[adipiciu]

I shortened the text under 255 length but it still doesn't show properly.

[adipiciu]

I propose to shorten the string, so it can fit and also to get rid of the validation warning.
If the string cannot fit, it adds ellipsis (...) and you won't understand anything anyway.

@douph1 what do you say?

[karianna]

I propose to shorten the string, so it can fit and also to get rid of the validation warning. If the string cannot fit, it adds ellipsis (...) and you won't understand anything anyway.

@douph1 what do you say?

If you just remove Eclipse or Temurin, would that fit?

[adipiciu]

If you just remove Eclipse or Temurin, would that fit?

Eclipse Temurin is a variable {vendor_branding}. But even if I remove that, it still doesn't fit completely.

[adipiciu]

This is the maximum we can fit (159 characters)

[douph1]

PR already merged