Update JDK22 Installer files for JDK22+36 Release #844
Conversation
steelhead31
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
steelhead31
force-pushed
the
upd_installers_jdk22
branch
from
cf4d9bf to
bda16e1
Compare
steelhead31
changed the title
| %global spec_release 1 | ||
| %global priority 1161 | ||
| %global priority 2200 |
There was a problem hiding this comment.
Where does this number come from? They don't seem to be consistent across versions.
There was a problem hiding this comment.
To the best of my knowledge, it has to be the same for all versions of a package. I don't think we actually use it anywhere, but maybe @jiekang can offer some insight ?
There was a problem hiding this comment.
It's used for the priority value in alternatives, a Linux tool for selecting the JDK to use for a system. For example here: https://github.com/adoptium/installer/blob/master/linux/jdk/redhat/src/main/packaging/temurin/21/temurin-21-jdk.spec#L166
The comments and usage in the Fedora spec share some insight:
https://src.fedoraproject.org/rpms/java-21-openjdk/blob/rawhide/f/java-21-openjdk.spec#_339
It looks like they should mimic the jdk version and be updated when releasing new versions.
There was a problem hiding this comment.
Thanks @jiekang I am writing some documentation about the installers, and how to update them so I'll include this note alongside the other things, I think 2200 is good for the base release then, but we could update it to follow, the fedora spec.. which I think would give us 22000036 for this release ?
# Using 10 digits may overflow the int used for priority, so we combine the patch and build versions
# It is very unlikely we will ever have a patch version > 4 or a build version > 20, so we combine as (patch * 20) + build.
# This means 11.0.9.0+11 would have had a priority of 11000911 as before
# A 11.0.9.1+1 would have had a priority of 11000921 (20 * 1 + 1), thus ensuring it is bigger than 11.0.9.0+11
%global combiver $( expr 20 '*' %{patchver} + %{buildver} )
%global priority %( printf '%02d%02d%02d%02d' %{featurever} %{interimver} %{updatever} %{combiver} )
|
/merge |
|
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
|
/approve |
1 similar comment
|
/approve |
These files have s390x removed due to some blocking tests, this PR will allow publishing of all other linux installers. A 2nd PR to publish the s390x installers ( and an additional one to come will also be made, to include riscv support )