Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store sharedClassesTestData using getResultsDir() instead of getPrereqRoots() #154

Closed
wants to merge 1 commit into from

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented May 31, 2024

  • SharedClasses tests to generate related classes under workspace dir - with getResultsDir function instead of getPrereqRoots.

related:eclipse-openj9/openj9#19582

@annaibm
Copy link
Contributor Author

annaibm commented May 31, 2024

@llxia
Copy link
Contributor

llxia commented Jun 3, 2024

@annaibm can you date the title to Store sharedClassesTestData using getResultsDir() instead of getPrereqRoots()?

@annaibm annaibm changed the title Removed the getPrereqRoots function Store sharedClassesTestData using getResultsDir() instead of getPrereqRoots() Jun 3, 2024
@annaibm annaibm marked this pull request as ready for review June 3, 2024 14:27
- Store sharedClassesTestData using getResultsDir() instead of getPrereqRoots().

related:eclipse-openj9/openj9#19582

Signed-off-by: Anna Babu Palathingal <[email protected]>
@llxia
Copy link
Contributor

llxia commented Jun 3, 2024

Can you also run extended.system on windows?

@llxia
Copy link
Contributor

llxia commented Jun 3, 2024

Just for the record, in order to pre-stage 3rd party system test jars change, getPrereqRoots() cannot be used for storing generated test data. This PR changes to use getResultsDir(), which changes the current behavior.

  • current behavior: sharedClassesTestData is generated under one fixed dir /home/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/. For example, if SharedClasses.SCM01.SingleCL generates sharedClassesTestData. It will be used for other SharedClasses tests (i.e., SharedClasses.SCM23.SingleCL, SharedClasses.SCM01.MultiCL, SharedClasses.SCM23.MultiCL, SharedClasses.SCM01.MultiThreadMultiCL, etc). Instead of Step 1 - Create Shared Classes jars, they will do Step 1 - Copy sharedClasses jar.
  • new behavior: since each test will generate sharedClassesTestData under its test result dir (i.e., /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_17171870437914/SharedClasses.SCM23.MultiCL_0/20240531-165032-SharedClasses/results/). Each test will generate its own sharedClasses jar.

I believe this new behavior does not change the actual tests. It will make the test more self contained.

@annaibm
Copy link
Contributor Author

annaibm commented Jun 4, 2024

@karianna
Copy link
Contributor

karianna commented Oct 2, 2024

@annaibm needs a rebase

@annaibm annaibm marked this pull request as draft October 2, 2024 18:04
@annaibm
Copy link
Contributor Author

annaibm commented Oct 2, 2024

@karianna Will need to close this PR as above usecase is got implemented using another approach in the below PR.

PR:#156. (Adds the classes.jar file contained in the SharedClassesTestdata to the sharedClassesTestData/v1/jdkversion directory)

@annaibm annaibm closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants