Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all references of support url github.com/AdoptOpenJDK/openjdk-support to github.com/adoptium/adoptium-support #2590

Closed
10 tasks
sophia-guo opened this issue Apr 19, 2021 · 13 comments
Assignees
Labels
documentation Issues that request updates to our documentation enhancement Issues that enhance the code or documentation of the repo in any way good first issue Issues that have been deemed "easy" and excellent for new contributors testing Issues that enhance or fix our test suites
Milestone

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Apr 19, 2021

Description
The repository is used to track issues raised by end-users against the adoptopenjdk binaries has been transferred to adoptium . We need update all references to adoptium.

Update: only two links left see comment #2590 (comment)

Tips to solve this particular issue:

To fix this issue, we need to replace https://github.com/AdoptOpenJDK/openjdk-support with https://github.com/adoptium/adoptium-support in the repo. Searching https://github.com/AdoptOpenJDK/openjdk-support in the repo there are 7 matches, [two of them](https://github.com/AdoptOpenJDK/openjdk-build/blob/master/sbin/build.sh#L239, https://github.com/AdoptOpenJDK/openjdk-build/blob/master/sbin/build.sh#L240) are for build parameter, one of them is for test, others are documents related.

📋 Step by Step

To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here. Note: that you do not need to add yourself to a Contributors.md file as outlined in the detailed instructions.

  • Claim this issue: Comment below.
  • Fork the repository in github by simply clicking the 'fork' button.
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have any naming definition for branches.
  • Commit your changes.
  • Start a Pull Request.
  • Done 👍 Ask in comments for a review :)
  • If the reviewer find some missing pieces or a problem they will start a discussion with you and describe the next steps how the problem can be solved.
  • You did it 🎉 We will merge the fix in the master branch.
  • Thanks, thanks, thanks for being part of this project as an open source contributor ❤️

🤔❓ Questions

@sophia-guo sophia-guo added the good first issue Issues that have been deemed "easy" and excellent for new contributors label Apr 19, 2021
@M-Davies M-Davies added documentation Issues that request updates to our documentation enhancement Issues that enhance the code or documentation of the repo in any way labels Apr 20, 2021
@ljessicc
Copy link

Hi, I could take care of this

@M-Davies M-Davies added this to the April 2021 milestone Apr 23, 2021
@ljessicc
Copy link

Please review the updated support references. Thank you

@M-Davies
Copy link

Are these the references you are referring to?

@ljessicc
Copy link

@M-Davies No, the support references.

@M-Davies
Copy link

I'm not sure what you are referring to in that case 🙂

@ljessicc
Copy link

I changed the existing URL https://github.com/AdoptOpenJDK/openjdk-support with github.com/adoptium/adoptium-support. Tried doing a pull request but was seeing a "There isn’t anything to compare" message. I merged master branch to the forked repo and did another pull request, so I hope it goes through.

@M-Davies
Copy link

Ah I see, I think you might have still been on your branch for #2584 when you pushed the changes that updated the URL. So now the changes you made to the URL are now included in that pull request too. It's not a problem, as I can just link that PR to this issue too.

@M-Davies M-Davies linked a pull request Apr 26, 2021 that will close this issue
@ljessicc
Copy link

@M-Davies Oh OK, Thank you

@karianna karianna modified the milestones: April 2021, June 2021 Jun 6, 2021
@github-actions github-actions bot added the testing Issues that enhance or fix our test suites label Jun 6, 2021
@sxa
Copy link
Member

sxa commented Jul 12, 2021

@ljessicc Are you still working on this?

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Sep 24, 2021

Update: some of the link has been updated. There are still two hyperlinks left in the file security/README.md.

support-issues
tsc-decision

@totorororo
Copy link
Contributor

I can work on this

@totorororo
Copy link
Contributor

Please review

@smlambert
Copy link
Contributor

Closed via #2739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues that request updates to our documentation enhancement Issues that enhance the code or documentation of the repo in any way good first issue Issues that have been deemed "easy" and excellent for new contributors testing Issues that enhance or fix our test suites
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants