Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GH Actions to use setup-java 2 and grab latest Java 17 for tip builds #2704

Closed
karianna opened this issue Sep 8, 2021 · 3 comments · Fixed by #2711
Closed

Upgrade GH Actions to use setup-java 2 and grab latest Java 17 for tip builds #2704

karianna opened this issue Sep 8, 2021 · 3 comments · Fixed by #2711
Assignees

Comments

@karianna
Copy link
Contributor

karianna commented Sep 8, 2021

@karianna Thanks for the review!

Build failures seem to be caused by:

warning: unknown enum constant Feature.SEALED_CLASSES
warning: unknown enum constant Feature.SEALED_CLASSES

That suggests the JDK 18 build uses a too old JDK 17 boot JDK. Uses 17+20. Should be 17+24 or better. See:
https://bugs.openjdk.java.net/browse/JDK-8260517

Either way, unrelated failures.

Originally posted by @jerboaa in #2702 (comment)

@gdams
Copy link
Member

gdams commented Sep 10, 2021

The build jobs actually use the API. I'll do some digging but I think we just need to switch to the Adoptium api to get the latest nightly builds.

@gdams
Copy link
Member

gdams commented Sep 10, 2021

Yup, see all the references in https://github.com/adoptium/temurin-build/search?q=api.adoptopenjdk.net&type= that need updating.

@karianna karianna self-assigned this Sep 10, 2021
@karianna
Copy link
Contributor Author

Yup, see all the references in https://github.com/adoptium/temurin-build/search?q=api.adoptopenjdk.net&type= that need updating.

Will do this post-release - I think much of that YAML needs updating to use the setup-java action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants