Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating source archives #2702

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Sep 7, 2021

This is useful to see the exact sources that were used when
building the JDK.

After this patch ./makejdk-any-platform.sh --create-source-archive can be used to produce -sources tarballs/zips.

Closes #2698

This is useful to see the exact sources that were used when
building the JDK.

Closes adoptium#2698
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - clean patch - thanks - will wait for test results

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 8, 2021

@karianna Thanks for the review!

Build failures seem to be caused by:

warning: unknown enum constant Feature.SEALED_CLASSES
warning: unknown enum constant Feature.SEALED_CLASSES

That suggests the JDK 18 build uses a too old JDK 17 boot JDK. Uses 17+20. Should be 17+24 or better. See:
https://bugs.openjdk.java.net/browse/JDK-8260517

Either way, unrelated failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add source tarball snapshots
3 participants