-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reproducible comparison tests on windows #3711
Comments
@sophia-guo the requirement for apt-cygwin is no longer relevant, as the playbooks have been updated to install jq , so there is no need for this... I'll put a PR in for this update. PR here.. #3718 |
Invalid build.sh option: --with-version-opt
https://ci.adoptium.net/view/Test_grinder/job/Grinder/9240/console @steelhead31 idea? |
configure: error: Your base path is too long. It is 170 characters long, but only 100 is supported Top dir
JDK build top dir:
This is specific to windows. In beta jdk build the TOPDIR is set as /cygdrive/c/workspace/openjdk-build, which is nothing related with the jenkins build job name. See the linux top dir is /home/jenkins/workspace/build-scripts/jobs/jdk21u/jdk21u-linux-x64-temurin/workspace/build/openjdkbuild. That is for windows due to the path lenght the topdir has been explicitly set to avoid this. In reproducible script it might also need to think about. @steelhead31 @andrew-m-leonard |
I think this is why I explicitly set a path from root originally , before I made the recent update to make it relative to the current working directory. |
I could update my script to have the WORK_DIR passed as the 3rd parameter, would that help ? |
I think we might just set similar to def workspace = 'C:/workspace/openjdk-build/'. As long as it's not the root one which jenkins doesn't have the permission. And then the final reproduced zip file should be moved to WORK_DIR so aqa-tests can have access for the result files. |
My script creates these 2 files.. Original JDK : "$WORK_DIR/src_jdk_dist.zip" and the results of the comparison also finish up here.. "$WORK_DIR/compare/repro_diff.out" Let me know if you'd like that changing, should be just some very minor amendments to my script |
@steelhead31 I think that should work |
@sophia-guo yeah I am not surprised by Windows, there is fudge for ci-jenkins-pipelines to do the same: |
@sophia-guo the PR for this script has now been merged :) |
@steelhead31 I didn't see the update of the WORKDIR ( working dir for build jdk) ? Build_JDK() . WORK_DIR="$CURR_DIR/cmp$(date +%Y%m%d%H%M%S)" will cause the configure: error: 'Your base path is too long ' in jenkins test environment. |
I'll take a look... |
@sophia-guo here is a PR, #3734 not sure what happened to the first commit... Now uses "C:/workspace/comp-jdk-build/" as a workdir |
Error: Cannot locate spec.gmk, given by SPEC=win_x86-64.
|
@sophia-guo I think the issue is the path again... have you definitely picked up my changes to fix the windows_repro_build_compare.sh script working directory... ? Line 43: 14:56:42 configure: error: Your base path is too long. It is 170 characters long, but only 100 is supported 14:56:42 configure exiting with result code 1 14:56:42 make[5]: Entering directory '/cygdrive/c/jenkins/workspace/Grinder/aqa-tests/TKG/output_17113746753551/Rebuild_Same_JDK_Reproducibility_Test_win_0/cmp20240325135117/temurin-build/workspace/build/src' 14:56:42 Error: Cannot locate spec.gmk, given by SPEC=win_x86-64. |
@steelhead31 I believe i picked up the changes. The grinder was not there anymore. I will rebase and rerun. |
Issues:
The text was updated successfully, but these errors were encountered: