-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the logic for launching tests #1125
Conversation
Can one of the admins verify this patch? |
@llxia Can you rebase, please? I'll also review and then get @johnoliver to take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - We'll need to coordinate the change but it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Are we ready for this to be merged yet?
@llxia is at a conference right now. I want to make sure we have generated the right jobs adoptium/aqa-tests#1168 in order to support this, so would like to wait to merge this for now. Waiting for a confirmation from Lan that we are good to go. |
With new test jobs are generated (test job name change), we need to update the way tests are launched Issue: adoptium#1116 Signed-off-by: lanxia <[email protected]>
Rebased. |
is it ready for merging? I am fine with this as is and I have added my approve. But presumably all the new test names that it refers to need to be in place, are they all ready to go? Also as this pull request is currently a Draft we are not able to merge it, so if it is ready to go let us know and make it a non-draft. |
I will test this PR using the pipeline build. If the test passes, I will change it to |
run tests |
Please see the following testing builds: https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk11u/job/jdk11u-linux-x64-openj9/6/ Test jobs are triggered and executed correctly. Please note external test jobs cannot be auto-gened as they are the top-level test jobs and have special configuration. I will manually rename the top level external test job names to match with the new naming convention once the PR is merged. This PR is ready to merge. |
Test runs look good, thanks @llxia ! Will merge now, as already 2 approvals |
With new test jobs are generated (test job name change), we need to
update the way tests are launched
Issue: #1116
Signed-off-by: lanxia [email protected]