Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the logic for launching tests #1125

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jun 18, 2019

With new test jobs are generated (test job name change), we need to
update the way tests are launched

Issue: #1116

Signed-off-by: lanxia [email protected]

@adoptopenjdk-github-bot
Copy link
Contributor

Can one of the admins verify this patch?

@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Jun 18, 2019
@karianna karianna added this to the June 2019 milestone Jun 18, 2019
@karianna karianna requested a review from johnoliver June 24, 2019 08:51
@karianna
Copy link
Contributor

@llxia Can you rebase, please? I'll also review and then get @johnoliver to take a look

@karianna karianna self-requested a review June 24, 2019 08:52
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - We'll need to coordinate the change but it looks good.

Copy link
Contributor

@johnoliver johnoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Are we ready for this to be merged yet?

@smlambert
Copy link
Contributor

@llxia is at a conference right now. I want to make sure we have generated the right jobs adoptium/aqa-tests#1168 in order to support this, so would like to wait to merge this for now. Waiting for a confirmation from Lan that we are good to go.

With new test jobs are generated (test job name change), we need to
update the way tests are launched

Issue: adoptium#1116

Signed-off-by: lanxia <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented Jul 3, 2019

@llxia Can you rebase, please? I'll also review and then get @johnoliver to take a look

Rebased.

@johnoliver
Copy link
Contributor

is it ready for merging? I am fine with this as is and I have added my approve. But presumably all the new test names that it refers to need to be in place, are they all ready to go?

Also as this pull request is currently a Draft we are not able to merge it, so if it is ready to go let us know and make it a non-draft.

@llxia
Copy link
Contributor Author

llxia commented Jul 4, 2019

I will test this PR using the pipeline build. If the test passes, I will change it to Ready for review.

@johnoliver
Copy link
Contributor

run tests

@llxia
Copy link
Contributor Author

llxia commented Jul 8, 2019

Please see the following testing builds:

https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk11u/job/jdk11u-linux-x64-openj9/6/
https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk11u/job/jdk11u-linux-x64-hotspot/126/
https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk8u/job/jdk8u-mac-x64-hotspot/7/

Test jobs are triggered and executed correctly. Please note external test jobs cannot be auto-gened as they are the top-level test jobs and have special configuration. I will manually rename the top level external test job names to match with the new naming convention once the PR is merged.

This PR is ready to merge.

@llxia llxia marked this pull request as ready for review July 8, 2019 18:06
@smlambert
Copy link
Contributor

Test runs look good, thanks @llxia ! Will merge now, as already 2 approvals

@smlambert smlambert merged commit e0db5e5 into adoptium:master Jul 8, 2019
@karianna karianna added this to the July 2019 milestone Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants