Ensure TemurinGenSOM.java build with jdk-17+ for openkeystore support #3236
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
| echo "${javaHome}" | ||
| } | ||
| # TemurinGenSBOM.java requires jdk-17+ to build openkeystore | ||
| apiURL="https://api.adoptium.net/v3/binary/latest/17/ga/${OPERATING_SYSTEM}/${BUILD_CONFIG[OS_ARCHITECTURE]}/jdk/hotspot/normal/eclipse" |
There was a problem hiding this comment.
Do we really need to do this? Most of our build machines have java 17 installed in a known location so downloading it every time seems a bit over the top.
Also does this process run on Solaris too?
There was a problem hiding this comment.
@sxa What environment would point at it?
Also, the above is generic for user of this script
There was a problem hiding this comment.
Yeah thought about Solaris, not sure what we do there....yet
There was a problem hiding this comment.
I'd like to just get some thing building rather than none :-)
There was a problem hiding this comment.
@sxa What environment would point at it?
Do you mean which path? /usr/lib/jvm/jdk-XX on linux for example - we create equivalent locations elsewhere.
Also, the above is generic for user of this script
Yes but "if it's not in our location, do the download" would seem a sensible thing to do (and the fewer things we download during the process the better and more secure we will be)
There was a problem hiding this comment.
So openkeystore is not going to build on Solaris, so I think we're going to have to re-factor that code out of TemurinGenSBOM and into another signing app, called in a standalone job
There was a problem hiding this comment.
@sxa in fact i'm thinking refactor the whole class into a separate invoked build-farm job, a bit like GPG signing. Trying to perform at the end of the build is troublsome
|
Needs re-working with thought on jdk8 Solaris and possibly other issues.. |
Fix build.sh to build TemurinGenSOM.java with jdk-17+ as openkeystore won't compile.
Fixes up: #3209
Signed-off-by: Andrew Leonard [email protected]