-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Reproducible Build From SBOM Scripts #3673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Issues that request updates to our documentation
label
Feb 28, 2024
steelhead31
added
enhancement
Issues that enhance the code or documentation of the repo in any way
windows
Issues that affect or relate to the WINDOWS OS
cmp-builds
and removed
documentation
Issues that request updates to our documentation
labels
Feb 28, 2024
github-actions
bot
added
the
documentation
Issues that request updates to our documentation
label
Feb 28, 2024
Add initial version of win repro script Make reproducible scripts less noisy Add reproducible patch functions to main scripts Add Win SDK Version To SBOM Restructure tooling scripts for clarity
steelhead31
force-pushed
the
add_win_sbom_repro
branch
from
March 1, 2024 08:50
0daacae
to
71245e0
Compare
github-actions
bot
added
macos
Issues that affect or relate to the MAC OS
testing
Issues that enhance or fix our test suites
labels
Mar 1, 2024
steelhead31
changed the title
Add win SBOM repro
Add Windows Reproducible Build From SBOM Scripts
Mar 1, 2024
Final output from script..
|
steelhead31
force-pushed
the
add_win_sbom_repro
branch
from
March 1, 2024 17:30
358c3c0
to
289256a
Compare
andrew-m-leonard
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work Scott
sophia-guo
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmp-builds
documentation
Issues that request updates to our documentation
enhancement
Issues that enhance the code or documentation of the repo in any way
macos
Issues that affect or relate to the MAC OS
testing
Issues that enhance or fix our test suites
windows
Issues that affect or relate to the WINDOWS OS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3426
This is the PR for the initial version of the windows reproducible build script, it covers these 5 tasks which were required to make this function correctly.
The script itself has been developed and tested extensively on an Adoptium Windows build machine, however it should work on any windows machine, that has been built and configured with the necessary (specific!) compiler versions.