Update build triage script to include pipeline analysis #3692
Conversation
This update primarily allows the script to correctly identify tag-driven build pipelines. JDK8 has three types of these, and all types should be located where possible. We can also ignore pipelines that are still running, as these will have incomplete results. User-launched pipelines will also be ignored, as the script cannot yet spot the difference between a rerun using default options, and an experimental rerun whose outcome should not be used to indicate the overall health of the build system. I have also repaired the bug where unstable builds are erroneously included in the list of failed builds. Unstable builds are typically passed builds which have a number of failed post-build unit tests. Lastly, we no longer expect arm32 builds on JDK21 and up. Minor cosmetic improvements included. Signed-off-by: Adam Farley <[email protected]>
github-actions
bot
added
arm
|
Tested here: https://github.com/adamfarley/temurin-build/actions/runs/8190313614/job/22397008637 Linter in progress. |
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Because the build triage script has no effect on the build pipeline, and this action wastes user time and machine time. Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
|
Made several style changes to satisfy the linter, and also improved logging. Also excluded the "build" github action for future build triage script changes. We don't need to test the build process against changes to the triage script, because build triage happens after the build pipeline is complete. |
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
adamfarley
force-pushed
the
update_build_triage_script
branch
from
4f586c5 to
fe4fead
Compare
Putting the new trigger at the end causes failure. Reordering. Signed-off-by: Adam Farley <[email protected]>
|
Added a couple of updates to the autotriage workflow:
The latest code changes were tested here: https://github.com/adamfarley/temurin-build/actions/runs/8203403503 |
|
Ready for reviews. Adding a link to #temurin-build Slack. |
|
Also, I tested the build.yml change here: I tested it by cloning this branch into a false "master" branch in my fork, and by making trivial changes to the build triage script in a second branch of this branch, before creating a PR from one to the other. The change to the build triage script should now not trigger the build workflow. Update: Confirmed. |
This update primarily allows the script to correctly identify
tag-driven build pipelines. JDK8 has three types of these, and
all types should be located where possible.
We can also ignore pipelines that are still running, as these will
have incomplete results.
User-launched pipelines will also be ignored, as the script cannot
yet spot the difference between a rerun using default options,
and an experimental rerun whose outcome should not be used to
indicate the overall health of the build system.
I have also repaired the bug where unstable builds are erroneously
included in the list of failed builds. Unstable builds are typically
passed builds which have a number of failed post-build unit tests.
Lastly, we no longer expect arm32 builds on JDK21 and up.
Minor cosmetic improvements included.