-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update variants to read from correct path in Tailwind 3.x #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, thx @jcayabyab! 👍🏼
@adoxography merge pls.
Please merge. Works as expected. |
Please! Merge it! Why is it taking so long? |
When is this merge going to happen ? |
@adoxography Please, can you Merge it! |
mergeeeeeeee!!!!! |
please merge |
@leonnicklas can anyone merge this? |
@alexincore sorry, don't have write access to merge it... As a workaround: Install this PR (by @jcayabyab) via npm until it get's merged officially... npm install adoxography/tailwind-scrollbar#pull/36/head |
@adoxography could you please merge this PR. Otherwise it prevents to use it fully with tailwind v3 Thanks by advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though in retrospect, this should really have been a plugin option, not a "variant" (since it's not a variant). I'll merge it as a hotfix for now.
Update variants to read from correct path in Tailwind 3.x
As per suggestion from #35 (comment). The variants has changed in Tailwind 3.x, and as such needs this change to read the value of the variants array.