Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variants to read from correct path in Tailwind 3.x #36

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

jcayabyab
Copy link
Contributor

@jcayabyab jcayabyab commented Mar 8, 2022

As per suggestion from #35 (comment). The variants has changed in Tailwind 3.x, and as such needs this change to read the value of the variants array.

Copy link

@leonnicklas leonnicklas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thx @jcayabyab! 👍🏼

@adoxography merge pls.

@iantearle
Copy link

Please merge. Works as expected.

@juninholiveira
Copy link

Please! Merge it! Why is it taking so long?

@kbysport24
Copy link

When is this merge going to happen ?

@Sarouche92
Copy link

@adoxography Please, can you Merge it!

@serudda
Copy link

serudda commented Jun 21, 2022

mergeeeeeeee!!!!!

@TxMat
Copy link

TxMat commented Jun 22, 2022

please merge

@alexincore
Copy link

@leonnicklas can anyone merge this?

@leonnicklas
Copy link

leonnicklas commented Jun 22, 2022

@alexincore sorry, don't have write access to merge it...

As a workaround:

Install this PR (by @jcayabyab) via npm until it get's merged officially...

npm install adoxography/tailwind-scrollbar#pull/36/head

@ilourt
Copy link

ilourt commented Jul 22, 2022

@adoxography could you please merge this PR. Otherwise it prevents to use it fully with tailwind v3

Thanks by advance

Copy link
Owner

@adoxography adoxography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though in retrospect, this should really have been a plugin option, not a "variant" (since it's not a variant). I'll merge it as a hotfix for now.

@adoxography adoxography merged commit 78b06f9 into adoxography:main Sep 4, 2022
adoxography added a commit that referenced this pull request Mar 20, 2023
Update variants to read from correct path in Tailwind 3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.