none-ls support #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoyle-h
requested changes
Sep 25, 2024
There was a problem hiding this comment.
This PR is incomplete. Please fix the bugs. And you also need to modify the codes in onSubmit function.
Please check your code with https://github.com/LuaLS/lua-language-server , and test it more comprehensively.
| local S = require('null-ls.sources') | ||
| local nullLS_present, nullLS = pcall(require, 'null-ls') | ||
| if not nullLS_present then | ||
| nullLS_present, nullLS = pcall(require, 'none-ls') |
There was a problem hiding this comment.
The package name is still 'null-ls' in https://github.com/nvimtools/none-ls.nvim.
The none-ls is https://github.com/nvimtools/none-ls-extras.nvim , but it is not required for none-ls.
| if not nullLS_present then | ||
| nullLS_present, nullLS = pcall(require, 'none-ls') | ||
| if nullLS_present then | ||
| local S = require('none-ls.sources') |
There was a problem hiding this comment.
The local variable defined in if block is invisible out of the if block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
What Changed
Add support for none-ls.
Motivation and Context
jose-elias-alvarez/null-ls.nvim has been deprecated for over a year, with the new active fork being nvimtools/none-ls.nvim.
Issues and links
None?
Type of change
Checklist