Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes #2

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Changes #2

wants to merge 10 commits into from

Conversation

East2West
Copy link

Added high-res artwork using LastFM api, implemented image caching for
album artwork for faster reloading when screen rotates, play button bug
fix

@East2West
Major stability changes:
8977192 
1. Most all Force Close's are gone.
	
Small Functional Changes:
1. Put the service in charge of going to the next song.
2. Added a custom broadcast and receiver to handle song changes
	a. Using the asynctask caused references to become "stale" when
configurations changed

Minor cosmetic changes:
1. Increased album imageview size
2. Added a custom landscape layout
3. Increased Text size.

Bugs:

1. If you log out while in the player, restart the app, and log back in
there's a bug in the pandora api that I can't seem to track down that
causes getStations in PandoraRadio.java to return null from a
XMLRPCFaultException. Only a complete kill/FC of the app seems to fix
it.
2. Probably others
@East2West
Added high-res artwork using LastFM api, implemented image caching for
7c4c6f5 
album artwork for faster reloading when screen rotates, play button bug
fix
@East2West
Changed AlbumArtDownloader to make it more likely to find difficult
db5e397 
track urls.
@adregner
Copy link
Owner

First, THANK YOU for all the work! I have actually been working on my own re-factoring of the PandoraRadio class(es) with the eventual goal of improving stability. I've already pulled your repo into my local system to start merging it with my work. I haven't compiled/reviewed everything in this pull request yet, but it appears that you have done most of your work on the front end/android stuff (com.aregner.android.pandoid package) and i have been working mostly on the pandora radio library (com.aregner.pandora).

I'll be finishing up my work soon, commit that, and then merge yours into it I think. It just may be a little while until I can get the time to resolve everything nicely. But thanks again, I'm really excited :-)

@East2West
Copy link
Author

But thanks again, I'm really excited :-)

You and me both! I've been looking for a good project to get me back into
programming and this was definitely it. I'll keep working on things in the
front end in the meantime. If there's any features you think would be needed
or any comments on the code I've added, feel free to ask.

On Sat, Oct 15, 2011 at 9:01 PM, Andrew Regner <
[email protected]>wrote:

First, THANK YOU for all the work! I have actually been working on my own
re-factoring of the PandoraRadio class(es) with the eventual goal of
improving stability. I've already pulled your repo into my local system to
start merging it with my work. I haven't compiled/reviewed everything in
this pull request yet, but it appears that you have done most of your work
on the front end/android stuff (com.aregner.android.pandoid package) and i
have been working mostly on the pandora radio library (com.aregner.pandora).

I'll be finishing up my work soon, commit that, and then merge yours into
it I think. It just may be a little while until I can get the time to
resolve everything nicely. But thanks again, I'm really excited :-)

Reply to this email directly or view it on GitHub:
#2 (comment)

@East2West
Fixed login/logout fc bug. The static vector "EMPTY_ARGS" in
ccf2292 
PandoraRadio.java turns into gibberish  if you disconnect and reconnect.
Making it non-static ensures this won't happen.

This, I believe is the same fc that happens if the player has been
paused for a long and attempts to reconnect.
@East2West
Added search functionality and ability to delete stations
d2f2afc
@East2West
New feature! Added the ability to replay songs from the recently played
44917a8 
list.Various bug fixes and improvements.
@East2West
Removed saving recentlyPlayed to the database. The links don't hold
9608d3d 
after your auth tokens change.
@East2West
Some code cleanup, added a loading animation to the album art.
92823b3
@East2West
Fixed a bug that was causing the search feature to crash.
bb2775a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@East2West @adregner