Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add support for go1.16's WalkDir #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darkliquid
Copy link
Contributor

Add support for using the faster WalkDir method when building against
go1.16.

This hopefully addresses the concerns with #15 by making this backwards compatible.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #22 (853d54f) into master (0b7b89d) will increase coverage by 56.18%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   10.34%   66.53%   +56.18%     
===========================================
  Files           4        6        +2     
  Lines         232      248       +16     
===========================================
+ Hits           24      165      +141     
+ Misses        208       71      -137     
- Partials        0       12       +12     
Impacted Files Coverage Δ
finder_dirwalk.go 58.33% <58.33%> (ø)
finder_walk.go 58.33% <58.33%> (ø)
finder.go 30.18% <100.00%> (+30.18%) ⬆️
registry.go 69.44% <0.00%> (+69.44%) ⬆️
utils.go 92.30% <0.00%> (+92.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Add support for using the faster WalkDir method when building against
go1.16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant