[WIP] Map functionality #50
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 96.34% 95.69% -0.65%
==========================================
Files 7 7
Lines 82 93 +11
==========================================
+ Hits 79 89 +10
- Misses 3 4 +1
Continue to review full report at Codecov.
|
|
Hi @jbrantly! It actually looks quite interesting! If you add support for other wrapper types (shallow and react wrappers), and add documentation and unit tests, I'd be happy to merge it! Thanks a lot for your contribution! |
|
FYI, I'm still planning on finishing this, just have to find the time. |
|
Hey @jbrantly, no problem, there's no rush at all! I made a few changes on |
|
Is this still in progress? @jbrantly |
|
Closing this as it hasn't been updated in a while, and a map functionality has been made by @pedrottimark in #56. |
Addresses #48
Instead of trying to explain what I meant I figured I'd just show. This is a partial implementation that only covers shallow rendering. In the added unit test, if mapping functionality was not available, the output would show
<Wrapper(BasicClass) />. With mapping we are able to unwrap the class and set the display to whatever we want. Of course the mapping would also allow many other kinds of modifications like changing props, children, etc.If you like this concept I can continue fleshing it out.
One big question I have is how you could pass options to the serializer, especially something like a mapping function.
Oh, and since I work on a Windows machine I needed to make a couple changes to allow the tests to run on Windows.