Refactor Speaker indexing into a Speaker::Index record. #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does take some extra work since Active Record can't detect `rowid` is the primary key. But with some awareness around that, it's pretty smooth sailing and we can entirely remove a lot of the custom SQL with standard Active Record.
kaspth
force-pushed
the
speaker-index-virtual-table-model
branch
from
1c21d37 to
ce24a50
Compare
adrienpoly
force-pushed
the
main
branch
2 times, most recently
from
97e3bb3 to
953a362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like GitHub doesn't support staged PRs on forks, so #540 needs to go in first and then this goes on top — I'll probably need to rebase this PR on main after #540.
Follow-up to #540