Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for latest stripe-js and react-stripe-js #147

Closed
SamyPesse opened this issue Jul 24, 2020 · 1 comment · Fixed by #175
Closed

Support for latest stripe-js and react-stripe-js #147

SamyPesse opened this issue Jul 24, 2020 · 1 comment · Fixed by #175

Comments

@SamyPesse
Copy link

react-stripe-js is doing a validation on the stripe object: https://github.com/stripe/react-stripe-js/blob/e13fae556b1a667a5dfa1130c00d5ec4c2bc154e/src/utils/guards.ts#L16

This validation is failing because of the missing createPaymentMethod

@adrienverge
Copy link
Owner

adrienverge commented Jul 27, 2020

Thanks for reporting, I didn't know that.

If you want to contribute, you could add a dump JavaScript method like this, and if you're motivated, implement it for real 👍

PS: The issue title talks about "latest stripe-js". Isn't it working?

brandondyck pushed a commit to brandondyck/localstripe that referenced this issue Feb 5, 2021
react-stripe-js checks for createPaymentMethod to validate the stripe
object. This fixes adrienverge#147.
adrienverge pushed a commit that referenced this issue Feb 6, 2021
react-stripe-js checks for createPaymentMethod to validate the stripe
object. This fixes #147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants