Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add axisymmetric argument to FieldsMixed #199

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Add axisymmetric argument to FieldsMixed #199

merged 11 commits into from
Apr 21, 2022

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Apr 20, 2022

Also fix wrong are normal of boundary regions.

Fixes #200

@adtzlr adtzlr added the enhancement New feature or request label Apr 20, 2022
@adtzlr adtzlr added this to the 3.0.0 milestone Apr 20, 2022
@adtzlr adtzlr self-assigned this Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #199 (223de8b) into main (3a623df) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   98.32%   98.31%   -0.01%     
==========================================
  Files          62       62              
  Lines        2504     2499       -5     
==========================================
- Hits         2462     2457       -5     
  Misses         42       42              
Impacted Files Coverage Δ
felupe/_assembly/_axi.py 100.00% <100.00%> (ø)
felupe/_field/_axi.py 95.45% <100.00%> (+1.01%) ⬆️
felupe/_field/_fields.py 100.00% <100.00%> (ø)
felupe/quadrature/_gausslegendre.py 100.00% <100.00%> (ø)
felupe/region/_boundary.py 100.00% <100.00%> (ø)
felupe/region/_templates.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a623df...223de8b. Read the comment docs.

@adtzlr adtzlr added the bug Something isn't working label Apr 21, 2022
@adtzlr adtzlr merged commit af10898 into main Apr 21, 2022
@adtzlr adtzlr deleted the add-axi-fieldsmixed branch April 21, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegionBoundary: Area normals are broken
2 participants