-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify handling of Field
and FieldMixed
#229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see #228
because it is available as a field attribute
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 98.28% 96.59% -1.70%
==========================================
Files 67 66 -1
Lines 2865 2760 -105
==========================================
- Hits 2816 2666 -150
- Misses 49 94 +45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This breaks backward compatibility.
Motivation
Due to different handlings of a default Field and a mixed Field, the code is unnecessary complex and hard to read. The idea is to unify both kind of Fields, using a FieldContainer (which is basically just a renamed FieldMixed). Beside a cleaner source code, the user interface improves by a unified field handling inside the forms and tools.
Furthermore, the current IntegralForm class should be hidden in the global namespace and be replaced by IntegralFormMixed as new IntegralForm.
This also improves the interface to matADi by avoiding the wrapper
MatadiMaterial
due to identical API.Tasks
u0ext
toext0
e0087ectest_readme.py
0c56754## Tasks...and a lot of small fixes...
Removed
fixes #228
fixes #230